-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65957/#review198838
-----------------------------------------------------------




docs/windows.md
Line 17 (original), 17 (patched)
<https://reviews.apache.org/r/65957/#comment279085>

    That works. I just didn't want to conflate with "free software" because VS 
is definitely not. Thanks!



docs/windows.md
Lines 99 (patched)
<https://reviews.apache.org/r/65957/#comment279087>

    Eh, if you have GCC installed on Windows, I figure you already know what 
you're doing. This was more of a "getting started" not how to fix any bug with 
it. Setting CXX and CC applies to more than just Ninja, too, that's generic 
CMake.


- Andrew Schwartzmeyer


On March 7, 2018, 12:58 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65957/
> -----------------------------------------------------------
> 
> (Updated March 7, 2018, 12:58 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, Eric 
> Mumau, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This notes that Developer Mode is required for non-admin symlinks,
> removes reference to the close JIRA epic, and adds information on how
> to build with Ninja on Windows.
> 
> 
> Diffs
> -----
> 
>   docs/windows.md cf2c7c230ec9fc062b4a4fe721d7669ef646253c 
> 
> 
> Diff: https://reviews.apache.org/r/65957/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Reply via email to