----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65312/#review198853 -----------------------------------------------------------
Fix it, then Ship it! Thanks Alexander, this is amazing! Much appreciated. And thanks to BenH for the inspiration :) src/master/http.cpp Line 867 (original), 838 (patched) <https://reviews.apache.org/r/65312/#comment279106> Nit: indented too far. src/master/http.cpp Line 4442 (original), 4138 (patched) <https://reviews.apache.org/r/65312/#comment279111> Nit: `&` is mis-placed. src/master/master.cpp Lines 11241-11242 (original), 11228-11229 (patched) <https://reviews.apache.org/r/65312/#comment279112> Nit: not indented enough. - Greg Mann On Feb. 27, 2018, 8:29 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65312/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2018, 8:29 a.m.) > > > Review request for mesos, Benjamin Hindman and Greg Mann. > > > Bugs: MESOS-8434 > https://issues.apache.org/jira/browse/MESOS-8434 > > > Repository: mesos > > > Description > ------- > > This patch makes uses of the new `ObjectApprovers` class which greatly > simplifies the logic for constructing and using authorization. > > > Diffs > ----- > > src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 > src/common/protobuf_utils.cpp f516091e9208552488c154f34adde6f20d3413bf > src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad > src/master/master.hpp 1fadbe61f774e8ca9926af4e39b3d6c8e24fe5df > src/master/master.cpp f2c2dbe6a4568027f11ad14121c2f9a1d1a43f80 > > > Diff: https://reviews.apache.org/r/65312/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
