----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65968/#review198910 -----------------------------------------------------------
Ship it! Adding a TODO to make other handlers also take rvalue? - Meng Zhu On March 7, 2018, 7:52 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65968/ > ----------------------------------------------------------- > > (Updated March 7, 2018, 7:52 p.m.) > > > Review request for mesos and Meng Zhu. > > > Bugs: MESOS-8628 > https://issues.apache.org/jira/browse/MESOS-8628 > > > Repository: mesos > > > Description > ------- > > The master's handlers should all take rvalue references for > consistency. > > > Diffs > ----- > > src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad > src/master/master.hpp c9c8a968b6f56fe261ac9fe374e926a28d40fccb > src/master/master.cpp e666b664dd125317cda5d16285d444b9c21e1f35 > > > Diff: https://reviews.apache.org/r/65968/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
