-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65906/#review198991
-----------------------------------------------------------




site/Gemfile
Lines 13 (patched)
<https://reviews.apache.org/r/65906/#comment279266>

    I wasn't sure about not specifying a version but you followed the 
recommendations in 
https://github.com/tzinfo/tzinfo/wiki/Resolving-TZInfo::DataSourceNotFound-Errors
    
    The issue seems to be Windows-only but specifying the `platforms` seems 
overkill: https://github.com/middleman/middleman/issues/1097


- Armand Grillet


On March 10, 2018, 5:49 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65906/
> -----------------------------------------------------------
> 
> (Updated March 10, 2018, 5:49 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Mahler, Greg Mann, and 
> haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated site's middleman to latest 3.x release.
> 
> 
> Diffs
> -----
> 
>   site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
>   site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
> 
> 
> Diff: https://reviews.apache.org/r/65906/diff/3/
> 
> 
> Testing
> -------
> 
> Locally tested the generated website: `bundle install && bundle exec rake && 
> bundle exec rake dev`.
> 
> The only manually updated file was `site/Gemfile`; `site/Gemfile.lock` was 
> updated automatically by `bundler`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to