----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66025/ -----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao. Bugs: MESOS-8656 https://issues.apache.org/jira/browse/MESOS-8656 Repository: mesos Description ------- Previsouly when converting a JSON to a protobuf message in stout, we cannot handle the fields like below which are actually valid. "int32": "-2147483647" "int64": "-9223372036854775807" "bool": "true" The conversion will fail with an error like "Not expecting a JSON string for field 'int32'". So in this patch, `Try<Nothing> operator()(const JSON::String& string)` was enhanced to be able to convert `JSON::String` to bool and integers. Diffs ----- 3rdparty/stout/include/stout/protobuf.hpp 4a1605e5130dbf7e8286dbb43d0d04ab4394e79a Diff: https://reviews.apache.org/r/66025/diff/1/ Testing ------- Thanks, Qian Zhang