> On March 9, 2018, 11:40 p.m., Jie Yu wrote: > > Looking good! Is it possible to add some test?
Working on the unit tests. - Sagar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65987/#review198968 ----------------------------------------------------------- On March 13, 2018, 11:10 p.m., Sagar Patwardhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65987/ > ----------------------------------------------------------- > > (Updated March 13, 2018, 11:10 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-8534 > https://issues.apache.org/jira/browse/MESOS-8534 > > > Repository: mesos > > > Description > ------- > > Continued from https://github.com/apache/mesos/pull/263 > > > Diffs > ----- > > src/master/validation.cpp f0b86775b > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 1d01915c2 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 896656987 > src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 7678a7c81 > src/slave/containerizer/mesos/isolators/network/cni/paths.cpp f9056c90f > > > Diff: https://reviews.apache.org/r/65987/diff/2/ > > > Testing > ------- > > Manually tested. > > Working on unit tests. > > > Thanks, > > Sagar Patwardhan > >
