----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199256 -----------------------------------------------------------
FAIL: Failed to apply the current review. Failed command: `python.exe .\support\apply-reviews.py -n -r 66001` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66001 Relevant logs: - [apply-review-66001-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66001/logs/apply-review-66001-stdout.log): ``` error: patch failed: src/slave/flags.cpp:1130 error: src/slave/flags.cpp: patch does not apply ``` - Mesos Reviewbot Windows On March 15, 2018, 1:27 p.m., Harold Dost wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66001/ > ----------------------------------------------------------- > > (Updated March 15, 2018, 1:27 p.m.) > > > Review request for mesos and James Peach. > > > Repository: mesos > > > Description > ------- > > New Flags for disk/xfs isolator > - This patch adds a number of flags to handle switching the limit in the > `disk/xfs` isolator to allow apps to go over their limit and for mesos > to kill them if they have gone over their limit. > > New Flags: > - xfs_disk_hard_limit_offset_pct - Use the `disk` as the soft limit and > set the hard limit to be some percentage above the soft limit. > Allowing > for containers to surpass a desired allocation and making them > killable. > - xfs_disk_hard_limit_offset - Use the `disk` as the soft limit and set > the hard limit to some number of bytes specified above the > applications to be a soft limit instead of a hard limit. > - xfs_kill_after_grace_period - This will kill tasks if they breach the > grace period configured using `xfs_quota -x -c "timer -p <time>"` > - xfs_kill_check_interval - The frequency with which a container will be > checked for soft limit violations. > > Functionality > - Add head room to the hard limit as a percentage or specified amount > for each container. This is specified at a flag level and not > customizable on a per container basis. > - Provide the ability for an application to be killed after the > configured grace period for projects is violated. > - Add an interval between which the watcher will check for violations. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > 07e68a777aefba4dd35066f2eb207bba7f199d83 > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > 8d9f8f846866f9de377c59cb7fb311041283ba70 > src/slave/containerizer/mesos/isolators/xfs/utils.hpp > e034133629a9c1cf58b776f8da2a93421332cee0 > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > 2708524add1ff693b616d4fb241c4a0a3070520b > src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e > src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc > src/tests/containerizer/xfs_quota_tests.cpp > ce69c882251c36cf50dc1b46dd0b9337bb7b5043 > > > Diff: https://reviews.apache.org/r/66001/diff/3/ > > > Testing > ------- > > > Thanks, > > Harold Dost > >
