----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66076/#review199349 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/tests/protobuf_tests.cpp Line 108 (original), 108 (patched) <https://reviews.apache.org/r/66076/#comment279652> Not sure what style is better. How about ``` string expected = R"~({ ... })~"; ``` Or ``` string expceted = R"~({ ... })~"; ``` ? - Chun-Hung Hsiao On March 15, 2018, 9:29 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66076/ > ----------------------------------------------------------- > > (Updated March 15, 2018, 9:29 a.m.) > > > Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao. > > > Repository: mesos > > > Description > ------- > > Used raw string literal in protobuf tests to avoid escaping. > > > Diffs > ----- > > 3rdparty/stout/tests/protobuf_tests.cpp > a0ef1d110204fe2868ac9b686da090d9e7b3d2a3 > > > Diff: https://reviews.apache.org/r/66076/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
