----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review199354 -----------------------------------------------------------
include/mesos/mesos.proto Lines 1967 (patched) <https://reviews.apache.org/r/66049/#comment279663> I'd suggest the following: ``` message GrowVolume { required Resource volume = 1; required Resource addition = 2; } ``` Using `Resource` for `addition` make it clear that you need an offer containing the resources to be able to grow an volume. You cannot bindly grown a volume. The master will validate that `addition` is actually allocated to the framework. The master will also need to validate that the `addition` Resource is compatible with `volume` in the operation. 1) If `volume` is a `ROOT` disk, `addition` has to be a `ROOT` disk too. 2) If `volume` is a `PATH` disk, the `addition` can either be a `PATH` disk with the same `Source`, or a `RAW` disk from the same resource provider and the same profile. 3) If `volume` is a `MOUNT` disk, the `addition` should be a `RAW` disk from the same resource provider and the same profile. Given that, using a `Resource` for `addition` is more appropriate and future proof. - Jie Yu On March 16, 2018, 5:54 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66049/ > ----------------------------------------------------------- > > (Updated March 16, 2018, 5:54 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Gaston Kleiman. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > Added offer operation to grow and shrink persistent volumes. > > > Diffs > ----- > > include/mesos/mesos.proto e6ba3746456c9241ceaefac39200f68562dd5cb9 > include/mesos/v1/mesos.proto 30d4d35e865db2af1ba85b12e2b5b0e499ef8de8 > > > Diff: https://reviews.apache.org/r/66049/diff/2/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
