-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66008/
-----------------------------------------------------------
(Updated March 19, 2018, 12:36 p.m.)
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John
Kordich, Joseph Wu, and Michael Park.
Changes
-------
Removed -Werror semantics, to be done later.
Bugs: MESOS-8033 and MESOS-8658
https://issues.apache.org/jira/browse/MESOS-8033
https://issues.apache.org/jira/browse/MESOS-8658
Repository: mesos
Description (updated)
-------
We had previously been using the default sets of warnings, but now we
use the same warnings as on Autotools. This meant disabling two common
possible-loss-of-data warnings on Windows that are not part of the
GNU/Clang default warnings.
This also replaces the use of `string(APPEND CMAKE_CXX_FLAGS)` with
the canonical command `add_compile_options`. Although generally the
use of `target_compile_options` is preferred, it would currently
result in a lot more churn, and the build already supports setting
these flags globally.
Diffs (updated)
-----
cmake/CompilationConfigure.cmake efee36c1ffda096a97af23d481fc0d0903124e54
Diff: https://reviews.apache.org/r/66008/diff/4/
Changes: https://reviews.apache.org/r/66008/diff/3-4/
Testing
-------
Thanks,
Andrew Schwartzmeyer
