----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66058/#review199492 -----------------------------------------------------------
Fix it, then Ship it! src/tests/mesos.hpp Lines 2581 (patched) <https://reviews.apache.org/r/66058/#comment279796> Could you use `foreach` here? - Greg Mann On March 16, 2018, 7:58 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66058/ > ----------------------------------------------------------- > > (Updated March 16, 2018, 7:58 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Zhitao Li. > > > Bugs: MESOS-8201 > https://issues.apache.org/jira/browse/MESOS-8201 > > > Repository: mesos > > > Description > ------- > > Added v1 versions of some test helpers/matchers. > > > Diffs > ----- > > src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19 > > > Diff: https://reviews.apache.org/r/66058/diff/1/ > > > Testing > ------- > > Used by the tests added in https://reviews.apache.org/r/66060/. > > > Thanks, > > Gaston Kleiman > >
