----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66097/#review199551 -----------------------------------------------------------
Ship it! Looking good. Surprised they didn't provide another name for the library as well. Could you expand the commit message a little to call out that this patch moves us off headers deprecated by upstream and we do not expect any functional changes? - Benjamin Bannier On March 15, 2018, 8:21 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66097/ > ----------------------------------------------------------- > > (Updated March 15, 2018, 8:21 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-8678 > https://issues.apache.org/jira/browse/MESOS-8678 > > > Repository: mesos > > > Description > ------- > > Adapted the new `grpcpp` C++ headers for gRPC v1.10 in Mesos. > > > Diffs > ----- > > configure.ac f3d11696240bbc0420c92792780c3658993456f1 > src/examples/test_csi_plugin.cpp 0f65c401bde8e32eea8f63f4bde829e3cff50a74 > src/tests/mock_csi_plugin.hpp c1a96973574628a261b3d727c764cd0de10a5268 > > > Diff: https://reviews.apache.org/r/66097/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
