----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66159/#review199545 -----------------------------------------------------------
Fix it, then Ship it! src/tests/mock_csi_plugin.hpp Line 71 (original), 74 (patched) <https://reviews.apache.org/r/66159/#comment279834> `#include <stout/none.hpp>` - Benjamin Bannier On March 20, 2018, 1:59 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66159/ > ----------------------------------------------------------- > > (Updated March 20, 2018, 1:59 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and > Joseph Wu. > > > Bugs: MESOS-8697 > https://issues.apache.org/jira/browse/MESOS-8697 > > > Repository: mesos > > > Description > ------- > > The `CSIClientTest.*` tests now use in-process channels instead of > Unix domain sockets, so it can be run on Windows. > > > Diffs > ----- > > src/csi/client.hpp 0ff97eea9f27bff0ce79acb5a212aaa7a4098a55 > src/tests/csi_client_tests.cpp 2c5dbb7d0f794cb520b0ca4e7761f8bb51ce5ab2 > src/tests/mock_csi_plugin.hpp c1a96973574628a261b3d727c764cd0de10a5268 > src/tests/mock_csi_plugin.cpp 46ca398e48578537393e4050c3a9920b367b8946 > > > Diff: https://reviews.apache.org/r/66159/diff/1/ > > > Testing > ------- > > sudo make check > > > NOTE: This is not tested on Windows yet. The CMake rules are added later in > the chain. > > > Thanks, > > Chun-Hung Hsiao > >
