----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66060/#review199451 -----------------------------------------------------------
Fix it, then Ship it! src/tests/storage_local_resource_provider_tests.cpp Lines 3323 (patched) <https://reviews.apache.org/r/66060/#comment279771> s/are/is/ src/tests/storage_local_resource_provider_tests.cpp Lines 3409 (patched) <https://reviews.apache.org/r/66060/#comment279916> Should we do `ASSERT_TRUE(resource.has_provider.id());` here? src/tests/storage_local_resource_provider_tests.cpp Lines 3417-3418 (patched) <https://reviews.apache.org/r/66060/#comment279917> Nit: could you switch the order of these lines? - Greg Mann On March 19, 2018, 6:09 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66060/ > ----------------------------------------------------------- > > (Updated March 19, 2018, 6:09 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Zhitao Li. > > > Bugs: MESOS-8201 > https://issues.apache.org/jira/browse/MESOS-8201 > > > Repository: mesos > > > Description > ------- > > Added end-to-end tests for operation feedback. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 264d42b57fe1a8ea04c1de0a10112878c7b45d39 > > > Diff: https://reviews.apache.org/r/66060/diff/2/ > > > Testing > ------- > > The tests passed over 1000 iterations on GNU/Linux. > > > Thanks, > > Gaston Kleiman > >
