-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66158/
-----------------------------------------------------------
(Updated March 21, 2018, 8:25 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and
Joseph Wu.
Changes
-------
Made copying of `shared_ptr` in `Channel` constructor explicit.
Bugs: MESOS-8697
https://issues.apache.org/jira/browse/MESOS-8697
Repository: mesos
Description
-------
The `GRPCClientTest.*` tests now uses in-process channels instead of
Unix domain sockets, except for `DiscardedBeforeServerStarted`, which is
disabled on Windowns for now.
Diffs (updated)
-----
3rdparty/libprocess/include/process/grpc.hpp
edaf0410c62454df53d06957a4a8f1f6027b00bb
3rdparty/libprocess/src/tests/grpc_tests.cpp
8bb517fb5659b7010a0fe8b7b90ebb3a5c9f1157
Diff: https://reviews.apache.org/r/66158/diff/3/
Changes: https://reviews.apache.org/r/66158/diff/2-3/
Testing
-------
sudo make check
NOTE: This is not tested on Windows yet. The CMake rules are added later in the
chain.
Thanks,
Chun-Hung Hsiao
