----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66206/#review199795 -----------------------------------------------------------
include/mesos/docker/v1.proto Line 67 (original), 57 (patched) <https://reviews.apache.org/r/66206/#comment280254> Since this is a public proto file, is there any endpoint or API that enables a user to directly use this proto message? If yes, then this seems a breaking change since the user may be providing the following json: ``` { "labels": [ { "key": "SOME_KEY", "value": "SOME_VALUE" } ] } ``` - Chun-Hung Hsiao On March 22, 2018, 6:56 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66206/ > ----------------------------------------------------------- > > (Updated March 22, 2018, 6:56 a.m.) > > > Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gilbert Song. > > > Bugs: MESOS-8702 > https://issues.apache.org/jira/browse/MESOS-8702 > > > Repository: mesos > > > Description > ------- > > Used native protobuf map in Docker v1 image spec. > > > Diffs > ----- > > include/mesos/docker/v1.proto 338675490b7e624196bbb745173daa028a13280c > src/docker/spec.cpp 15224f90f965079ff83dfedff0182a97a5ff0360 > src/slave/containerizer/mesos/isolators/gpu/volume.cpp > 536a3c711faf3c165bebaaa3c92717737d67b6f3 > src/tests/containerizer/docker_spec_tests.cpp > 5fde49a495c2a2fa880e7cb1bae2f636edecd480 > > > Diff: https://reviews.apache.org/r/66206/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
