----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/#review199898 -----------------------------------------------------------
I only looked at https://reviews.apache.org/r/66037/diff/3-4/, because the rest was reviewed by Jan. I think that it looks good, I only added a comment regarding style, but I am also OK with the current version. src/tests/scheduler_tests.cpp Lines 1121-1136 (patched) <https://reviews.apache.org/r/66037/#comment280410> Nit: this might be a matter of taste, but I think that the following is easier to follow: ``` slaveFlags.agent_features = SlaveCapabilities(); foreach (const SlaveInfo::Capability slaveCapability &, slave::AGENT_CAPABILITIES()) { if (capability.type() != SlaveInfo::Capability::RESOURCE_PROVIDER) { slaveFlags.agent_features->add_capability()->CopyFrom(slaveCapability); } } ``` - Gaston Kleiman On March 23, 2018, 8:07 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66037/ > ----------------------------------------------------------- > > (Updated March 23, 2018, 8:07 a.m.) > > > Review request for mesos, Gaston Kleiman, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-8647 > https://issues.apache.org/jira/browse/MESOS-8647 > > > Repository: mesos > > > Description > ------- > > This patch add `RESOURCE_PROVIDER` to the list of default-enabled > agent capabilities. In addition we also adjust tests to accommodate > the change in the agent registration protocol this triggers. We rely > on masters ignoring redundant `UpdateSlaveMessage`s. > > > Diffs > ----- > > src/slave/constants.cpp 9b60bd0e808aab272039239db95bee71a3d910ab > src/tests/agent_resource_provider_config_api_tests.cpp > bd5312b71f500a3572362a39f22d742c621762cf > src/tests/api_tests.cpp 7e9233eae8d06a2513f71a17c429d04b9017154c > src/tests/master_tests.cpp 85a509a14d1e96f10b65d7df854cf83de3fa48f6 > src/tests/oversubscription_tests.cpp > 564405743cbf5805e79c04c7b37df505e988d984 > src/tests/persistent_volume_endpoints_tests.cpp > b9dbb96da5dc89b658f1618fb3a8b2fcc6b9f1b9 > src/tests/persistent_volume_tests.cpp > 924d8458e54e34a49c99593482b5908c5f7c7a48 > src/tests/reservation_endpoints_tests.cpp > 51146ea04fcd04efd489386be861415e2a066606 > src/tests/reservation_tests.cpp 8d8e9c8390e65187269bd194bb322bbdff88e0bd > src/tests/resource_provider_manager_tests.cpp > 718436e1c62ba3115a4408540b8d745a6f48cbfe > src/tests/scheduler_tests.cpp 1b9b39f7bf6ed69a4fd7a6c4735f55c53aaf6140 > src/tests/slave_recovery_tests.cpp 4a5860c37c63ae1338734e62db2066033e899fc9 > src/tests/slave_tests.cpp 028cd32c7043eba4e6f2045956471bd0bf42371c > src/tests/storage_local_resource_provider_tests.cpp > 49aa4ffa0d518c49f6061d572d8c7900c31600a4 > support/mesos-mini/Dockerfile f9bcdb59d233ddfa0a4523c84057c630d1d636a0 > support/mesos-mini/mesos/agent_features.json > a66852aff91e4b0c9ea996123cb6466a5ee0a050 > > > Diff: https://reviews.apache.org/r/66037/diff/4/ > > > Testing > ------- > > `sudo make check` > > > Thanks, > > Benjamin Bannier > >
