----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66235/#review199978 -----------------------------------------------------------
Fix it, then Ship it! src/launcher/default_executor.cpp Lines 1146-1147 (original), 1146-1147 (patched) <https://reviews.apache.org/r/66235/#comment280491> Can you also please add a comment here saying that ideally we should act on this kill's failure and not even send `TASK_KILLING` in this case? Please reference https://issues.apache.org/jira/browse/MESOS-8726 as well. It would be also great if you can reference two strategies we discussed offline: 1) extra state aka `initiating kill` + timeout and 2) allowing multiple kill requests to the agent at a time. - Alexander Rukletsov On March 23, 2018, 2:17 a.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66235/ > ----------------------------------------------------------- > > (Updated March 23, 2018, 2:17 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-8557 > https://issues.apache.org/jira/browse/MESOS-8557 > > > Repository: mesos > > > Description > ------- > > Added a reference to MESOS-8557 to the default executor. > > > Diffs > ----- > > src/launcher/default_executor.cpp 906836f3b8e0af79d7c61f90fd8a95f193b26e84 > > > Diff: https://reviews.apache.org/r/66235/diff/1/ > > > Testing > ------- > > > Thanks, > > Gaston Kleiman > >
