----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66218/#review200062 -----------------------------------------------------------
src/slave/slave.cpp Lines 4169-4184 (patched) <https://reviews.apache.org/r/66218/#comment280701> This is not a `set` operation but a `hashset` operation, so the comments are incorrect. Could you experiment on adding this operaton in `stout/hashset.hpp` and see if it works? - Chun-Hung Hsiao On March 27, 2018, 6:36 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66218/ > ----------------------------------------------------------- > > (Updated March 27, 2018, 6:36 a.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > Previously, `slave::syncCheckpointedResources` implementation will > delete a persistent volume using `Resources::contains` check, which > could cause a resized volume being deleted. The function was rewritten > to compare `set_difference` between old and new paths for all persistent > volumes and perform creation/deletion accordingly. > > > Diffs > ----- > > src/slave/slave.cpp e76daabad0d2d68aa42d1da809d4a23459eaaacb > > > Diff: https://reviews.apache.org/r/66218/diff/3/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
