-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66050/#review200071
-----------------------------------------------------------




src/slave/slave.cpp
Line 4258 (original), 4258 (patched)
<https://reviews.apache.org/r/66050/#comment280721>

    Could you split the agent changes into a separate patch? This is a 
significant functional change for the agent; I think it would be good to have 
it explicitly represented in the commit log.



src/slave/slave.cpp
Lines 4321-4323 (patched)
<https://reviews.apache.org/r/66050/#comment280723>

    Indented too far.



src/slave/slave.cpp
Line 4320 (original), 4335 (patched)
<https://reviews.apache.org/r/66050/#comment280722>

    We don't need to set the latest status here; that field is meant to be used 
during status update retries when there is a more recent status which we want 
to include as well.



src/slave/slave.cpp
Lines 8054-8056 (patched)
<https://reviews.apache.org/r/66050/#comment280724>

    Looks like we will now run `checkpointResources()` on resource provider 
resources which are contained in a speculative operation - this will violate a 
check in the agent: 
https://github.com/apache/mesos/blob/21e4b45b388d0b272236b1c58313569f8a1d1fc8/src/slave/slave.cpp#L4088


- Greg Mann


On March 27, 2018, 6:30 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66050/
> -----------------------------------------------------------
> 
> (Updated March 27, 2018, 6:30 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
>     https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new offer operations are implemented as non-speculative operations,
> which means they cannot be chained with previous offer operations which
> depend on results of each other.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.cpp 2acdc798200e82d14651b1edcc5f83e174477d53 
>   src/common/resources_utils.cpp 9be01c1abd48264e308960f35cc7c2ee8a367518 
>   src/master/master.cpp 20692c36c021fdae91de0b156f26fc56cf7c4f45 
>   src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf 
>   src/master/validation.cpp 9254cd22e67d9aca53135701575fb0857ff6f7d6 
>   src/slave/slave.cpp e76daabad0d2d68aa42d1da809d4a23459eaaacb 
>   src/tests/mesos.hpp 01fd1c2bf21ef96dbab0769a1c1c92d7e3b60032 
>   src/tests/persistent_volume_tests.cpp 
> 924d8458e54e34a49c99593482b5908c5f7c7a48 
>   src/tests/reservation_tests.cpp 8d8e9c8390e65187269bd194bb322bbdff88e0bd 
> 
> 
> Diff: https://reviews.apache.org/r/66050/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Reply via email to