----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66325/#review200104 -----------------------------------------------------------
src/resource_provider/daemon.cpp Line 186 (original), 187 (patched) <https://reviews.apache.org/r/66325/#comment280750> has RP ID already been brought into alignment here? src/resource_provider/daemon.cpp Lines 239 (patched) <https://reviews.apache.org/r/66325/#comment280751> ditto, has RP ID already been brought into alignment? - James DeFelice On March 28, 2018, 3:06 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66325/ > ----------------------------------------------------------- > > (Updated March 28, 2018, 3:06 a.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. > > > Bugs: MESOS-8742 > https://issues.apache.org/jira/browse/MESOS-8742 > > > Repository: mesos > > > Description > ------- > > `ADD_RESOURCE_PROVIDER_CONFIG`, `UPDATE_RESOURCE_PROVIDER_CONFIG` and > `REMOVE_RESOURCE_PROVIDER_CONFIG` now return 200 for identical > repetivite calls. > > > Diffs > ----- > > src/resource_provider/daemon.cpp d0a8186da80a1bffbb71f524e639bc7d75ef6243 > src/slave/http.cpp 65081c95c888a8236aafdfc627a7aa4e9a72b65d > > > Diff: https://reviews.apache.org/r/66325/diff/1/ > > > Testing > ------- > > make > > NOTE: Test `*/AgentResourceProviderConfigApiTest.RemoveNotFound` won't pass > since the semantics of `REMOVE_RESOURCE_PROVIDER_CONFIG` is changed. > Tests are added in the next patch. > > > Thanks, > > Chun-Hung Hsiao > >
