> On March 30, 2018, 8:34 a.m., David Forsythe wrote: > > src/CMakeLists.txt > > Line 35 (original) > > <https://reviews.apache.org/r/66371/diff/1/?file=1990431#file1990431line35> > > > > Should this line be removed? > > Chun-Hung Hsiao wrote: > This line is the same as Line 31. The review board is not clever enough > to mark the intended one ;)
Ah, of course. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66371/#review200228 ----------------------------------------------------------- On March 29, 2018, 11:58 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66371/ > ----------------------------------------------------------- > > (Updated March 29, 2018, 11:58 p.m.) > > > Review request for mesos, Benjamin Bannier, David Forsythe, and Jan Schlicht. > > > Bugs: MESOS-8749 > https://issues.apache.org/jira/browse/MESOS-8749 > > > Repository: mesos > > > Description > ------- > > The `major` and `minor` macros defined on some systems conflict with > field names in the CSI v0.1.0 spec proto. Temporarily disable it in > CMake until CSI is bumped to 0.2. > > > Diffs > ----- > > src/CMakeLists.txt fb9e9d4cfc4a62830fe3065a139ae14401c0e52e > > > Diff: https://reviews.apache.org/r/66371/diff/1/ > > > Testing > ------- > > `make check` with CMake > > > Thanks, > > Chun-Hung Hsiao > >
