----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/#review200324 -----------------------------------------------------------
src/slave/slave.cpp Line 2166 (original), 2221-2227 (patched) <https://reviews.apache.org/r/66126/#comment281021> Ah whoops, we should defer this continuation to `self()`. I think it's probably safe at the moment, but best to always defer/dispatch except for trivial continuations which do not access actor state. Even if the current implementation is safe, it makes the code less fragile if we defer. - Greg Mann On April 2, 2018, 5:57 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66126/ > ----------------------------------------------------------- > > (Updated April 2, 2018, 5:57 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-8617 and MESOS-8624 > https://issues.apache.org/jira/browse/MESOS-8617 > https://issues.apache.org/jira/browse/MESOS-8624 > > > Repository: mesos > > > Description > ------- > > This helps to encapsulate a task launch into a single > future which will come in handy when enforcing the task > launch order. > > This patch also consolidated the error handling code > in the task launch path. > > Affected tests are also updated. > > > Diffs > ----- > > src/slave/slave.hpp 37f0361251524e63d02d251e8a03901812b8affb > src/slave/slave.cpp a4bd4ccd3fc59c3c0e462d9b480f5424b3e52d7a > src/tests/mock_slave.hpp 8ec2b65a75f774d970ef6507df8b0c02fda5f2fd > src/tests/mock_slave.cpp 8ec55b6aa84dd8b1c3743cbcdc246311585d0f63 > src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 > > > Diff: https://reviews.apache.org/r/66126/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
