> On April 2, 2018, 8:42 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 359-360 (original), 365-366 (patched) > > <https://reviews.apache.org/r/66314/diff/1/?file=1989124#file1989124line365> > > > > If I understood the above discussion correctly, I think the following > > would work well: > > > > Use `${CMAKE_MAKE_PROGRAM}` and `${CMAKE_MAKE_PROGRAM} install` for the > > BUILD/INSTALL commands, instead of adding `${GNU_MAKE}`. > > > > Then in the MesosConfigure.cmake, we can have a platform check `if > > (FREEBSD) ... make sure CMAKE_MAKE_PROGRAM is gmake` or something to that > > effect. > > David Forsythe wrote: > If we do that, we would be forcing gmake for the entire build, right? > It's not clear to me that is the best approach, since the only problem is > leveldb (and since newer versions of leveldb seem to use cmake?). I might > even be more incline to try patching LevelDBs Makefile rather than force that.
@andschwa: `CMAKE_MAKE_PROGRAM` would point to whatever generator the user of the cmake build selected which does not necessarily implement `make` functionality (e.g., `ninja`, msvc, etc). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200305 ----------------------------------------------------------- On April 2, 2018, 8:36 p.m., David Forsythe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66314/ > ----------------------------------------------------------- > > (Updated April 2, 2018, 8:36 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. > > > Bugs: MESOS-4176 > https://issues.apache.org/jira/browse/MESOS-4176 > > > Repository: mesos > > > Description > ------- > > Fix 3rdparty build commands for FreeBSD. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 > cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c > > > Diff: https://reviews.apache.org/r/66314/diff/1/ > > > Testing > ------- > > cmake --build on FreeBSD > > > Thanks, > > David Forsythe > >
