> On April 3, 2018, 10:40 a.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 4969 (patched) > > <https://reviews.apache.org/r/66145/diff/4/?file=1985629#file1985629line4969> > > > > Is this necessary?
To avoid uninteresting mock call. > On April 3, 2018, 10:40 a.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 5049-5051 (patched) > > <https://reviews.apache.org/r/66145/diff/4/?file=1985629#file1985629line5049> > > > > Should we confirm here that the second task has not launched yet? > > > > i.e. > > ``` > > ASSERT_TRUE(taskStarting2.isPending()); > > ``` > > > > > > Also, enclose `taskGroup2` in backticks, here and below. Good point. - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66145/#review200376 ----------------------------------------------------------- On March 21, 2018, 2:57 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66145/ > ----------------------------------------------------------- > > (Updated March 21, 2018, 2:57 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-8617 and MESOS-8624 > https://issues.apache.org/jira/browse/MESOS-8617 > https://issues.apache.org/jira/browse/MESOS-8624 > > > Repository: mesos > > > Description > ------- > > Agent should launch the task in their receiving order. > On the task launch path, there are currently two > asynchronous steps which may complete out of order: > unschedule GC and task authorization. > > This test simulates the reordering of the completions > of unschedule GC step and verify that, despite the > reordering, tasks can still launch in their original order. > > > Diffs > ----- > > src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 > > > Diff: https://reviews.apache.org/r/66145/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
