-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66165/#review200448
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/master_allocator_tests.cpp
Lines 912-913 (original), 889-891 (patched)
<https://reviews.apache.org/r/66165/#comment281198>

    This is a multi-agent test, please restore to its original form.



src/tests/master_allocator_tests.cpp
Lines 968-969 (original), 943-945 (patched)
<https://reviews.apache.org/r/66165/#comment281199>

    Also a multi-agent test, please restore to its original form.


- Benjamin Bannier


On March 20, 2018, 9:36 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66165/
> -----------------------------------------------------------
> 
> (Updated March 20, 2018, 9:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8613
>     https://issues.apache.org/jira/browse/MESOS-8613
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the slave has a very short lifetime, its scheduled registration
> retry might occur when the test is tearing down. These unintuitively
> motivated registrations in turn cause additional invocations of
> `AddSlave` on the allocator.
> Additionally, this also reverts the newly introduced Clock pauses as
> they have shown to be problematic.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_allocator_tests.cpp 
> 1ceb8e8a57ab300a957931d5ad3d54904e555597 
> 
> 
> Diff: https://reviews.apache.org/r/66165/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> Ran the MasterAllocatorTests 10k times without any hiccups.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Reply via email to