----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66431/#review200469 -----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/ftruncate.hpp Lines 16-33 (original), 16-38 (patched) <https://reviews.apache.org/r/66431/#comment281210> This all belongs in its own commit. Oops. - Andrew Schwartzmeyer On April 3, 2018, 10:50 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66431/ > ----------------------------------------------------------- > > (Updated April 3, 2018, 10:50 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8676 > https://issues.apache.org/jira/browse/MESOS-8676 > > > Repository: mesos > > > Description > ------- > > This can eventually support overlapped I/O. > > The Windows API `ReadFile()` returns an error if the pipe is broken, > where `_read()` did not, but this is not an error for us as the data > is still read correctly. So we ignore it. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/ftruncate.hpp > fc4a8b5040d56fa9766687e44ce17fbe47d9e8f0 > 3rdparty/stout/include/stout/os/windows/read.hpp > 8047ad590fcc46d3ec46b551472d8c518ae49cc1 > > > Diff: https://reviews.apache.org/r/66431/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
