----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66432/#review200601 -----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/write.hpp Lines 35 (patched) <https://reviews.apache.org/r/66432/#comment281369> Same comment as previous read.hpp: Do you know why the return value is `ssize_t` instead of a `Try<size_t>`. Is it due to it being async signal safe? I imagine the callers of this function will check for error using `errno` then? Since we aren't using the CRT anymore, we might need to map some Windows errors to errno... - Akash Gupta On April 4, 2018, 5:50 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66432/ > ----------------------------------------------------------- > > (Updated April 4, 2018, 5:50 a.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8676 > https://issues.apache.org/jira/browse/MESOS-8676 > > > Repository: mesos > > > Description > ------- > > This can eventually support overlapped I/O. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/write.hpp > 71006489918d9495d37d2fdfdca08b40b419481a > > > Diff: https://reviews.apache.org/r/66432/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
