-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66445/
-----------------------------------------------------------
(Updated April 6, 2018, 4:18 p.m.)
Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and
Michael Park.
Changes
-------
Rebased.
Bugs: MESOS-8759
https://issues.apache.org/jira/browse/MESOS-8759
Repository: mesos
Description
-------
The set `errno` value in `os::kill()` is never checked (especially on
Windows), so `_set_errno()` and thus `errno.h` were removed.
The `fcntl.h` is used only to provide `O_CREAT` etc., and so belonged
in `open.hpp`, not `windows.hpp`.
The remaining headers, `direct.h`, `io.h`, `process.h`, and `stdlib.h`
were no longer used or needed as the respective CRT APIs were
replaced.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/windows/kill.hpp
9cec1117fac3cf6bd624fc7db524ef1ad10cd55d
3rdparty/stout/include/stout/os/windows/mkdtemp.hpp
9181429383a991fe2b87701d2bfd0e858ac2537b
3rdparty/stout/include/stout/os/windows/open.hpp PRE-CREATION
3rdparty/stout/include/stout/os/windows/rmdir.hpp
a2926dab2c8e219cf5938c4df27f83488198dd6b
3rdparty/stout/include/stout/os/windows/sendfile.hpp
fff5872db6b3f69464e41e6d108a107e4eeabd12
3rdparty/stout/include/stout/windows.hpp
1bfcdf4a5c097cc6d2293396ce39c8ad2c9ec993
3rdparty/stout/include/stout/windows/dynamiclibrary.hpp
5b3cbf4f36ea9ac0411df52b4cfea8ef75fecbb5
3rdparty/stout/include/stout/windows/os.hpp
900baf9be4e3089cb43e444b14b155a80bcd1591
Diff: https://reviews.apache.org/r/66445/diff/2/
Changes: https://reviews.apache.org/r/66445/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer
