> On April 6, 2018, 2:01 p.m., Greg Mann wrote:
> > src/internal/evolve.hpp
> > Lines 120 (patched)
> > <https://reviews.apache.org/r/66461/diff/1/?file=1992542#file1992542line123>
> >
> >     Is the `mesos::` necessary in the type of the response argument here? 
> > Ditto in the implementation.

Nope, I removed it from this function here and cleaned up the rest of the 
evolve functions on this RR: https://reviews.apache.org/r/66489/


- Gaston


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66461/#review200669
-----------------------------------------------------------


On April 6, 2018, 5:16 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66461/
> -----------------------------------------------------------
> 
> (Updated April 6, 2018, 5:16 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an evolve function for `v1::scheduler::Response`.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp e00ac7175438f758b10c0aa9485fc29ffa4efa29 
>   src/internal/evolve.cpp f598ea11b64bdbface5bf1f124a02ea876196b67 
> 
> 
> Diff: https://reviews.apache.org/r/66461/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Reply via email to