-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66508/#review200738
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66508]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 9, 2018, 2:07 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66508/
> -----------------------------------------------------------
> 
> (Updated April 9, 2018, 2:07 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We require a certain number of offers in
> `SlaveTest.ResourceProviderPublishAll`, so we need to make sure that
> the agent knows all resources available during the test before offers
> are being generated.
> 
> In this patch we await all `UpdateSlaveMessage` from the agent to make
> sure the agent has seen all resources. Only then do we register a
> framework. This greatly minimizes the risk of not seeing the expected
> number of offers which now should only happen if due to
> master-internal message reordering the allocator sees the framework
> before it sees the latest agent resource update.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 646a2b9e046fb37dbe0610ea0848b50192913deb 
> 
> 
> Diff: https://reviews.apache.org/r/66508/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to