> On April 9, 2018, 2:51 p.m., Akash Gupta wrote:
> > 3rdparty/libprocess/src/http_proxy.cpp
> > Lines 159 (patched)
> > <https://reviews.apache.org/r/66440/diff/2/?file=1993516#file1993516line159>
> >
> >     There's also `ERROR_PATH_NOT_FOUND`. To be safe, you might want to 
> > check both.

I didn't see `CreateFile` state it could set this... but who knows; yeah let's 
be safe.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66440/#review200764
-----------------------------------------------------------


On April 6, 2018, 4:17 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66440/
> -----------------------------------------------------------
> 
> (Updated April 6, 2018, 4:17 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8675
>     https://issues.apache.org/jira/browse/MESOS-8675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced `open()` with `os::open()` in `http_proxy.cpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/http_proxy.cpp 
> 25d63791e4788a488f96303aabeed0fa77ad7992 
> 
> 
> Diff: https://reviews.apache.org/r/66440/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Reply via email to