----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66468/#review200769 -----------------------------------------------------------
Nice tests! src/tests/operation_reconciliation_tests.cpp Lines 123 (patched) <https://reviews.apache.org/r/66468/#comment281622> Not indented far enough. src/tests/operation_reconciliation_tests.cpp Lines 364-365 (patched) <https://reviews.apache.org/r/66468/#comment281634> Is there a reason not to do this with a `for` loop? src/tests/operation_reconciliation_tests.cpp Lines 461 (patched) <https://reviews.apache.org/r/66468/#comment281635> Can we eliminate this local variable? src/tests/operation_reconciliation_tests.cpp Lines 592 (patched) <https://reviews.apache.org/r/66468/#comment281640> As discussed in chat, we can probably remove this test. src/tests/operation_reconciliation_tests.cpp Lines 804 (patched) <https://reviews.apache.org/r/66468/#comment281639> s/belongs// src/tests/operation_reconciliation_tests.cpp Lines 910 (patched) <https://reviews.apache.org/r/66468/#comment281641> Not indented far enough. src/tests/operation_reconciliation_tests.cpp Lines 990-992 (patched) <https://reviews.apache.org/r/66468/#comment281642> Remove this newline. src/tests/operation_reconciliation_tests.cpp Lines 1019-1021 (patched) <https://reviews.apache.org/r/66468/#comment281643> Remove this newline. - Greg Mann On April 9, 2018, 9:53 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66468/ > ----------------------------------------------------------- > > (Updated April 9, 2018, 9:53 p.m.) > > > Review request for mesos and Greg Mann. > > > Repository: mesos > > > Description > ------- > > Added tests for operation status reconciliation. > > > Diffs > ----- > > src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a > src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 > src/tests/operation_reconciliation_tests.cpp PRE-CREATION > src/tests/storage_local_resource_provider_tests.cpp > 2872f1aec1a7b94fc302a533f5ae9e1be9658087 > > > Diff: https://reviews.apache.org/r/66468/diff/1/ > > > Testing > ------- > > The new tests passed 1000 iterations on GNU/Linux. > > > Thanks, > > Gaston Kleiman > >
