----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66511/#review200830 -----------------------------------------------------------
src/tests/containerizer.cpp Lines 534-535 (original), 535-537 (patched) <https://reviews.apache.org/r/66511/#comment281734> Indentation, here and elsewhere: ``` Future<Option<mesos::slave::ContainerTermination>> ( TestContainerizerProcess::*destroy)(const ContainerID&) = &TestContainerizerProcess::destroy; ``` src/tests/containerizer/composing_containerizer_tests.cpp Line 118 (original), 119 (patched) <https://reviews.apache.org/r/66511/#comment281735> Is it not possible to simply use `None()` here and elsewhere? - Greg Mann On April 9, 2018, 3:45 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66511/ > ----------------------------------------------------------- > > (Updated April 9, 2018, 3:45 p.m.) > > > Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian > Zhang. > > > Bugs: MESOS-8710 > https://issues.apache.org/jira/browse/MESOS-8710 > > > Repository: mesos > > > Description > ------- > > As the return type of `destroy()` method has been changed, we need to > update tests accordingly. This patch fixes all tests affected by the > change. > > > Diffs > ----- > > src/tests/cluster.cpp 97dde00bbd32d763c961e6ad2b323fb0ca3d774f > src/tests/containerizer.hpp d6a69d6327018065453f8a6cb275d921d10c9198 > src/tests/containerizer.cpp 13a290ff60e359ceced95b20cb9db8c25cd59dbc > src/tests/containerizer/composing_containerizer_tests.cpp > 09f7ea42dd833c36aefdb073517d809431c4f328 > src/tests/containerizer/docker_containerizer_tests.cpp > c198ecbac50ef4eb7ea243bebc17b65db7ce5cb7 > src/tests/containerizer/io_switchboard_tests.cpp > 8fdaa7ffb11d3cc48e1a2f4eaa086adda2837106 > src/tests/containerizer/mesos_containerizer_tests.cpp > 4fce8af7c89fd3b9166e1784203f99853624faef > src/tests/containerizer/mock_containerizer.hpp > 01c617a55899a7125ca1dc80091aef5603419ee8 > > > Diff: https://reviews.apache.org/r/66511/diff/1/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
