----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66578/ -----------------------------------------------------------
Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park. Bugs: MESOS-3441 https://issues.apache.org/jira/browse/MESOS-3441 Repository: mesos Description ------- Fixed `os::sleep()` to return an invalid parameter error if given a negative value. Fixed tests around the `cloexec` and `nonblock` stubs. Extended the `bootid` test to use `std::chrono` to assert the boot id (which is the system boot time) is a reasonable value. Permanently disabled `OsTest.Libraries` because there is no equivalent. Diffs ----- 3rdparty/stout/include/stout/os/windows/bootid.hpp d24e115b97ebcabfa808a9437fb41512f25a5271 3rdparty/stout/include/stout/windows/os.hpp 900baf9be4e3089cb43e444b14b155a80bcd1591 3rdparty/stout/tests/os_tests.cpp 4221ecdcefb5602ece20cc90b13c3f17057fcb4d Diff: https://reviews.apache.org/r/66578/diff/1/ Testing ------- Thanks, Andrew Schwartzmeyer