-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66540/#review200977
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 1709 (patched)
<https://reviews.apache.org/r/66540/#comment281896>

    s/verify/verifies/



src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 1709-1710 (patched)
<https://reviews.apache.org/r/66540/#comment281915>

    I do not see how the agent metadata is removed in this test, I think it is 
simulated by L1792:
    ```
    AWAIT_READY(containerizer->recover(state));
    ```
    
    So I would suggest to add a comment for L1792 to mention that we simulate 
agent metadata removed by passing an empty slave state into 
`containerizer->recover()`.


- Qian Zhang


On April 11, 2018, 7:41 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66540/
> -----------------------------------------------------------
> 
> (Updated April 11, 2018, 7:41 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-8416
>     https://issues.apache.org/jira/browse/MESOS-8416
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test for recovering nested container without slave state.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
> 796bc401d4f922e7a6bd9e5391003cddd4331c95 
> 
> 
> Diff: https://reviews.apache.org/r/66540/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> Verified that the test crashes without the fix in r/66539.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to