-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66541/#review200982
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/default_executor_tests.cpp
Lines 1477-1478 (patched)
<https://reviews.apache.org/r/66541/#comment281918>

    A newline between.



src/tests/default_executor_tests.cpp
Lines 1502 (patched)
<https://reviews.apache.org/r/66541/#comment281916>

    It seems we do not need this since scheduler will not connect with master 
more than once.


- Qian Zhang


On April 12, 2018, 4:40 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66541/
> -----------------------------------------------------------
> 
> (Updated April 12, 2018, 4:40 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-8416
>     https://issues.apache.org/jira/browse/MESOS-8416
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added default executor test for agent recovery without metadata.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 
> 293dd20d882447401572835bd31e197faf76861b 
> 
> 
> Diff: https://reviews.apache.org/r/66541/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> Verified that the test crashes without the fix in r/66539.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to