-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66410/#review201018
-----------------------------------------------------------


Fix it, then Ship it!





src/resource_provider/storage/provider.cpp
Line 726 (original), 724 (patched)
<https://reviews.apache.org/r/66410/#comment281956>

    Using `ContainerID()` here is a bit weird.
    
    Can you do the following? `Option<T>` defines `==` for `T` as the argument.
    ```
    if (nodeContainerId == containerId ||
        controllerContainerId == containerId)
    ```


- Jie Yu


On April 11, 2018, 2:34 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66410/
> -----------------------------------------------------------
> 
> (Updated April 11, 2018, 2:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8717
>     https://issues.apache.org/jira/browse/MESOS-8717
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch contains necessary changes for the storage local resource
> provider to use CSI v0.2. Support for the `STAGE_UNSTAGE_VOLUME` CSI
> node service capability is not implemented in this patch yet.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp 
> a07620d1c4bf618f669575b3e183bf598da905a6 
> 
> 
> Diff: https://reviews.apache.org/r/66410/diff/3/
> 
> 
> Testing
> -------
> 
> This patch cannot be compiled standalone. Tests done later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Reply via email to