----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66493/#review201039 -----------------------------------------------------------
Fix it, then Ship it! cmake/CompilationConfigure.cmake Lines 308 (patched) <https://reviews.apache.org/r/66493/#comment281966> Drop _on_. - Benjamin Bannier On April 12, 2018, 7:13 a.m., David Forsythe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66493/ > ----------------------------------------------------------- > > (Updated April 12, 2018, 7:13 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. > > > Bugs: MESOS-8761 > https://issues.apache.org/jira/browse/MESOS-8761 > > > Repository: mesos > > > Description > ------- > > Made FreeBSD default to non-GNU ld. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c > > > Diff: https://reviews.apache.org/r/66493/diff/3/ > > > Testing > ------- > > make on FreeBSD, with both lld and gold. > > > Thanks, > > David Forsythe > >
