-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66418/#review201054
-----------------------------------------------------------


Fix it, then Ship it!





src/resource_provider/storage/provider.cpp
Line 2076 (original), 2076-2083 (patched)
<https://reviews.apache.org/r/66418/#comment281999>

    Discussed offline. Let's move this to the caller and make this function a 
pure helper doing controller publish.



src/resource_provider/storage/provider.cpp
Lines 2194-2196 (original), 2190-2197 (patched)
<https://reviews.apache.org/r/66418/#comment282001>

    Ditto.


- Jie Yu


On April 11, 2018, 2:37 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66418/
> -----------------------------------------------------------
> 
> (Updated April 11, 2018, 2:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8717
>     https://issues.apache.org/jira/browse/MESOS-8717
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, when a `ControllerPublishVolume` or a `NodePublishVolume`
> fails, SLRP assumes the volume states remain unchanged, which are not
> suggested by the CSI spec. This patch handles such failures properly.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp 
> a07620d1c4bf618f669575b3e183bf598da905a6 
> 
> 
> Diff: https://reviews.apache.org/r/66418/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Reply via email to