> On April 12, 2018, 9:44 a.m., Andrew Schwartzmeyer wrote: > > src/CMakeLists.txt > > Lines 32-35 (patched) > > <https://reviews.apache.org/r/66577/diff/1/?file=1996857#file1996857line32> > > > > Nit: can this be moved down so it goes "no options", "grpc option", > > "java option", "internal option." > > Chun-Hung Hsiao wrote: > I put it in this order because this is from the 3rdparty bundle and > (although there is no public Mesos proto that uses CSI for now) this opens > the possiblity to let a public Mesos proto to use CSI.
Gotcha. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66577/#review201012 ----------------------------------------------------------- On April 11, 2018, 6:39 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66577/ > ----------------------------------------------------------- > > (Updated April 11, 2018, 6:39 p.m.) > > > Review request for mesos, Benjamin Bannier, Benno Evers, and Jie Yu. > > > Bugs: MESOS-8724 > https://issues.apache.org/jira/browse/MESOS-8724 > > > Repository: mesos > > > Description > ------- > > CSI proto compilation is disabled due to MESOS-8724, which is resolved > by bumping CSI to v0.2. This patch enables the compilation again. > > > Diffs > ----- > > src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9 > src/Makefile.am 257ff0e8d21e5240c27a123ed0cd563214e24fce > src/slave/flags.cpp bdfc49a3903899b2741bb60c7e9e89f0196492e4 > src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5 > > > Diff: https://reviews.apache.org/r/66577/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
