> On April 16, 2018, 5:38 p.m., Gaston Kleiman wrote: > > src/master/validation.cpp > > Lines 2348-2351 (patched) > > <https://reviews.apache.org/r/66050/diff/10/?file=2002407#file2002407line2348> > > > > Isn't it easier to do the following? > > > > ``` > > if (growVoluem.addition.scalar.value() <= 0) { > > ... > > ``` > > Chun-Hung Hsiao wrote: > The `Scalar` comparison contains a fixed-point conversion: > https://github.com/apache/mesos/blob/master/src/common/values.cpp#L103 > > Gaston Kleiman wrote: > This isn't obvious to the uninformed reader (aka me). Can we add a > comment here?
To be honest, the fixed-point conversion seems not necessary here. But this is consistent with how we check for empty resource in `src/common/resources.cpp`. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review201229 ----------------------------------------------------------- On April 16, 2018, 5:09 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66050/ > ----------------------------------------------------------- > > (Updated April 16, 2018, 5:09 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > The new offer operations are implemented as speculative operations, but > we will use validation to make them non-speculative on API level so that > we can transition later without a breaking change. > > > Diffs > ----- > > src/common/protobuf_utils.cpp 141a444534b776a2c90e2a0daf9727cd21e39080 > src/common/resources_utils.cpp 9be01c1abd48264e308960f35cc7c2ee8a367518 > src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a > src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf > src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d > > > Diff: https://reviews.apache.org/r/66050/diff/10/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
