----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66434/#review201455 -----------------------------------------------------------
Ship it! Ship It! - Joseph Wu On April 4, 2018, 12:18 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66434/ > ----------------------------------------------------------- > > (Updated April 4, 2018, 12:18 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8682 > https://issues.apache.org/jira/browse/MESOS-8682 > > > Repository: mesos > > > Description > ------- > > Previously, `os::open()` used the CRT function `_wopen()`, and so this > file was written to use the `CreateFile()` API directly. Now that > `os::open()` uses the Windows API, all this duplicate code can be > deleted in favor of using the `os::open()` and > `internal::windows::set_inherit()`. The major benefit here is that the > logic now almost exactly matches the POSIX counterpart in > `subprocess_posix.cpp`, to the point that we may want to recombine > these files in the future. > > > Diffs > ----- > > 3rdparty/libprocess/src/subprocess_windows.cpp > 1a91fbe7aeb44174ccfa2e7e299bc7dd52a11b8a > > > Diff: https://reviews.apache.org/r/66434/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
