----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66699/#review201474 -----------------------------------------------------------
3rdparty/stout/include/stout/windows/os.hpp Lines 43 (patched) <https://reviews.apache.org/r/66699/#comment282721> Instead of including it in `os.hpp`, it should be included in each file that uses it, and removed from both `os.hpp` headers (per [developer guide](https://mesos.apache.org/documentation/latest/developer-guide/#include-what-you-use)). I've run into this myself a few times, and the approach described in the guide is what Jie asked me to follow; we've just not managed to do this for every file yet (I previously did it for `os::realpath`). - Andrew Schwartzmeyer On April 18, 2018, 1:55 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66699/ > ----------------------------------------------------------- > > (Updated April 18, 2018, 1:55 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > The header 'write.hpp' was included from 'posix/os.hpp', but > not from 'windows/os.hpp', possible leading to subtle build > failures. > > > Diffs > ----- > > 3rdparty/stout/include/stout/windows/os.hpp > 900baf9be4e3089cb43e444b14b155a80bcd1591 > > > Diff: https://reviews.apache.org/r/66699/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
