----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66310/#review201475 -----------------------------------------------------------
src/resource_provider/manager.hpp Lines 42 (patched) <https://reviews.apache.org/r/66310/#comment282722> `process::Owned<mesos::resource_provider::Registrar>&& registrar`? Also it seems to me that the `mesos::` prefix can be omitted. src/resource_provider/manager.cpp Line 160 (original), 161 (patched) <https://reviews.apache.org/r/66310/#comment282723> `Owned<Registrar>&& _registrar`? src/slave/slave.cpp Lines 8869-8871 (patched) <https://reviews.apache.org/r/66310/#comment282730> The current implementation makes this assertion never fail ;) src/slave/slave.cpp Lines 8873 (patched) <https://reviews.apache.org/r/66310/#comment282731> This is completely redundent because of line 8848. - Chun-Hung Hsiao On April 10, 2018, 12:07 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66310/ > ----------------------------------------------------------- > > (Updated April 10, 2018, 12:07 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-8735 > https://issues.apache.org/jira/browse/MESOS-8735 > > > Repository: mesos > > > Description > ------- > > In order to support recovering resource provider manager information > in the future, we need to adjust the construction of the manager to be > able to consume a registrar. > > This patch lays the groundwork by adjusting interfaces and their > usage; we will make use of the passed on information in a following > patch. > > > Diffs > ----- > > src/resource_provider/manager.hpp bc017fa3998b780cec82718cabe2a8b470a66db2 > src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a > src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5 > src/tests/resource_provider_manager_tests.cpp > c52541bf130ccf4795b989b53331176a64a097ea > > > Diff: https://reviews.apache.org/r/66310/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
