----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66700/#review201490 -----------------------------------------------------------
Ship it! I applied and tested this chain manually, it fixed the build and the unit tests passed. I am not sure what's going on with the build bot right now. - Andrew Schwartzmeyer On April 18, 2018, 1:56 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66700/ > ----------------------------------------------------------- > > (Updated April 18, 2018, 1:56 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > The function os::shell is not implemented on Windows, > making it necessary to either hide all calls behind a > preprocessor macro or to avoid the function. > > > Diffs > ----- > > 3rdparty/libprocess/src/memory_profiler.cpp > b2174ba8ce9f10b268736678e3d92b175f6d1247 > > > Diff: https://reviews.apache.org/r/66700/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
