> On April 19, 2018, 12:19 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/registrar.hpp > > Line 113 (original), 114 (patched) > > <https://reviews.apache.org/r/66309/diff/3/?file=1995440#file1995440line115> > > > > `process::Owned<state::Storage>&& storage`?
See above. > On April 19, 2018, 12:19 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/registrar.cpp > > Line 163 (original), 151 (patched) > > <https://reviews.apache.org/r/66309/diff/3/?file=1995441#file1995441line163> > > > > `Owned<Storage>&& _storage`? The parameter has an underscore below. We use the underscore to disambiguate the different names to readers. It is required below, but not here. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66309/#review201476 ----------------------------------------------------------- On April 19, 2018, 11:19 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66309/ > ----------------------------------------------------------- > > (Updated April 19, 2018, 11:19 a.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-8735 > https://issues.apache.org/jira/browse/MESOS-8735 > > > Repository: mesos > > > Description > ------- > > This patch changes the way the storage backing an agent's resource > provider registrar is created: while before we created it implicitly > when constructing the registrar, we now consume storage passed on > construction. > > Being able to explicitly inject the used storage simplifies testing. > > > Diffs > ----- > > src/resource_provider/registrar.hpp > 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45 > src/resource_provider/registrar.cpp > 92ef9aecb1e93d10f46e53984391558f9901a60b > src/tests/resource_provider_manager_tests.cpp > c52541bf130ccf4795b989b53331176a64a097ea > > > Diff: https://reviews.apache.org/r/66309/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
