----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66746/ -----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Till Toenshoff. Repository: mesos Description ------- The MessageDifferencer utility has been available since protobuf 3.0.0. When comparing most repeated fields, we treat them as sets so the order of elements doesn't matter. In some exceptional cases, we treat them as list so the order becomes important. Further, fields with default purposes are considered to be set for comparison purposes. Diffs ----- include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb src/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2 src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf Diff: https://reviews.apache.org/r/66746/diff/1/ Testing ------- `make check` currently fails with: DefaultExecutorCheckTest.CommandCheckSharesWorkDirWithTask DefaultExecutorCheckTest.MultipleTasksWithChecks Thanks, Kapil Arya
