----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66727/#review201661 -----------------------------------------------------------
3rdparty/grpc-1.10.0.patch Lines 9-19 (patched) <https://reviews.apache.org/r/66727/#comment283193> We discussed this a bit, and it's just... weird. gRPC should not be _requiring_ `_WIN32_WINNT` to be defined. Chun, I think, perhaps, could we just change `#error` to `#warning`? Changing the ordering also ensure it gets defined before the check, but really just solves our problem by happenstance. - Andrew Schwartzmeyer On April 19, 2018, 7:24 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66727/ > ----------------------------------------------------------- > > (Updated April 19, 2018, 7:24 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph > Wu. > > > Bugs: MESOS-7881 > https://issues.apache.org/jira/browse/MESOS-7881 > > > Repository: mesos > > > Description > ------- > > We added a gRPC patch file that includes > https://github.com/grpc/grpc/pull/15128 to fix Windows compilation, and > updated `grpc.md` to match the format of `protobuf.md`. > > > Diffs > ----- > > 3rdparty/grpc-1.10.0.patch PRE-CREATION > 3rdparty/grpc-1.10.0.readme d33a80881f9660e95cf3c2b032b3053d5ed9c7ff > 3rdparty/grpc.md PRE-CREATION > > > Diff: https://reviews.apache.org/r/66727/diff/1/ > > > Testing > ------- > > N/A > > > Thanks, > > Chun-Hung Hsiao > >
