-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66621/
-----------------------------------------------------------
(Updated avr. 21, 2018, 11:22 matin)
Review request for mesos, Alexander Rojas and Till Toenshoff.
Bugs: MESOS-8788
https://issues.apache.org/jira/browse/MESOS-8788
Repository: mesos
Description
-------
Add support for alg RS256 to JWT library.
Diffs (updated)
-----
3rdparty/libprocess/include/process/jwt.hpp
768cbf6fa91537ff9f45f236f4033097c5cea959
3rdparty/libprocess/include/process/ssl/utilities.hpp
b7cc31c33fd35c93754407f8b350eeb993177f1d
3rdparty/libprocess/src/jwt.cpp 921031e6fe3ced5a6be6bc96190fae6d8282ae26
3rdparty/libprocess/src/ssl/utilities.cpp
4d3727daf53ec62a19255da5a9804d342e770ec2
3rdparty/libprocess/src/tests/jwt_keys.hpp PRE-CREATION
3rdparty/libprocess/src/tests/jwt_tests.cpp
eb36a9aed3b11208c7cdc6f20b5347f46821a207
Diff: https://reviews.apache.org/r/66621/diff/4/
Changes: https://reviews.apache.org/r/66621/diff/3-4/
Testing
-------
make check
I added the same tests than the ones for HS256 (i.e., validation in following
cases: bad header, bad payload, unknown alg, unsupported alg, valid token etc..
and creation of a valid token). I also added a test to verify that the
validation of a RS256 token fails when using the wrong public key.
Thanks,
Clement Michaud
